The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of value in org.jclouds.collect.InputSupplierMap.get(Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 71 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.crypto.SshKeys.readLengthFirst(InputStream) ignores result of java.io.InputStream.read(byte[], int, int) | BAD_PRACTICE | RR_NOT_CHECKED | 121 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.encryption.internal.Base64.decode(String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 780 | High |
org.jclouds.encryption.internal.Base64.encodeBytes(byte[], int, int, int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 503 | High |
org.jclouds.encryption.internal.Base64.encodeObject(Serializable, int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 374 | High |
Can't close bis since it is always null in org.jclouds.encryption.internal.Base64.decodeFromFile(String) | CORRECTNESS | NP_CLOSING_NULL | 957 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.http.HttpRequest.getSkips() may expose internal representation by returning HttpRequest.skips | MALICIOUS_CODE | EI_EXPOSE_REP | 176 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
format string "%3$s" needs argument 3 but only 2 are provided in new org.jclouds.http.HttpResponseException(HttpCommand, HttpResponse, String, Throwable) | CORRECTNESS | VA_FORMAT_STRING_MISSING_ARGUMENT | 61 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.http.handlers.BackoffLimitedRetryHandler.INSTANCE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 83 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Field JavaUrlHttpCommandExecutorService.logger masks field in superclass org.jclouds.http.internal.BaseHttpCommandExecutorService | CORRECTNESS | MF_CLASS_MASKS_FIELD | 77 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.internal.ClassMethodArgs.getArgs() may expose internal representation by returning ClassMethodArgs.args | MALICIOUS_CODE | EI_EXPOSE_REP | 54 | Medium |
new org.jclouds.internal.ClassMethodArgs(Class, Method, Object[]) may expose internal representation by storing an externally mutable object into ClassMethodArgs.args | MALICIOUS_CODE | EI_EXPOSE_REP2 | 40 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.io.ContentMetadataBuilder.contentMD5(byte[]) may expose internal representation by storing an externally mutable object into ContentMetadataBuilder.contentMD5 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 89 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.jclouds.io.internal.BasePayloadSlicer.doSlice(File, long, long) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 77 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.jclouds.io.payloads.BaseImmutableContentMetadata(String, Long, byte[], String, String, String) may expose internal representation by storing an externally mutable object into BaseImmutableContentMetadata.contentMD5 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 45 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new org.jclouds.io.payloads.ByteArrayPayload(byte[], byte[]) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 37 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.io.payloads.Part doesn't override DelegatingPayload.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 82 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new org.jclouds.io.payloads.StringPayload(String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 41 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Changes to logger could be lost in org.jclouds.json.config.GsonModule.provideGson(GsonModule$JsonBallAdapter, GsonModule$DateAdapter, GsonModule$ByteListAdapter, GsonModule$ByteArrayAdapter, GsonModule$SerializePropertiesDefaults, GsonModule$JsonAdapterBindings) | EXPERIMENTAL | LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE | 75 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.jclouds.json.internal.EnumTypeAdapterThatReturnsFromValue.deserialize(JsonElement, Type, JsonDeserializationContext) | STYLE | REC_CATCH_EXCEPTION | 53 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.jclouds.rest.Providers.getSupportedProvidersOfType(Class) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 67 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.jclouds.rest.RestContextFactory.getPropertiesFromResource(String) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 144 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.rest.RestContextSpec.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 90 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.jclouds.http.HttpRequest to org.jclouds.rest.internal.GeneratedHttpRequest in org.jclouds.rest.binders.BindMapToStringPayload.bindToRequest(HttpRequest, Map) | STYLE | BC_UNCONFIRMED_CAST | 51 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.rest.internal.GeneratedHttpRequest doesn't override org.jclouds.http.HttpRequest.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 42 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method call in org.jclouds.rest.internal.RestAnnotationProcessor.decorateRequest(GeneratedHttpRequest) passes null to a nonnull parameter of com.google.common.base.Preconditions.checkNotNull(Object, Object) | CORRECTNESS | NP_NONNULL_PARAM_VIOLATION | 983 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.jclouds.util.PasswordGenerator.goodChar should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 48 | Medium |