The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.jclouds.blobstore.TransientAsyncBlobStore.createUpdatedCopyOfBlobInContainer(String, Blob), since all org.jclouds.io.payloads.ByteArrayPayload are instances of org.jclouds.io.payloads.ByteArrayPayload | STYLE | BC_VACUOUS_INSTANCEOF | 535 | Medium |
| Method org.jclouds.blobstore.TransientAsyncBlobStore.getBlob(String, String, GetOptions) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 649 | Medium |
| Possible null pointer dereference of container in org.jclouds.blobstore.TransientAsyncBlobStore.putBlob(String, Blob) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 507 | High |
| Possible null pointer dereference of container in org.jclouds.blobstore.TransientAsyncBlobStore.putBlobAndReturnOld(String, Blob) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 520 | High |
| org.jclouds.blobstore.TransientAsyncBlobStore.putBlob(String, Blob) forgets to throw new IllegalStateException(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 502 | High |
| org.jclouds.blobstore.TransientAsyncBlobStore.putBlobAndReturnOld(String, Blob) forgets to throw new IllegalStateException(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 515 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.jclouds.blobstore.domain.internal.BlobBuilderImpl$PayloadBlobBuilderImpl be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.domain.internal.BlobMetadataImpl doesn't override StorageMetadataImpl.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.domain.internal.MutableBlobMetadataImpl doesn't override org.jclouds.domain.internal.MutableResourceMetadataImpl.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.domain.internal.MutableStorageMetadataImpl.getLastModified() may expose internal representation by returning MutableStorageMetadataImpl.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 66 | Medium |
| org.jclouds.blobstore.domain.internal.MutableStorageMetadataImpl.setLastModified(Date) may expose internal representation by storing an externally mutable object into MutableStorageMetadataImpl.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 74 | Medium |
| org.jclouds.blobstore.domain.internal.MutableStorageMetadataImpl doesn't override org.jclouds.domain.internal.MutableResourceMetadataImpl.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.domain.internal.StorageMetadataImpl.getLastModified() may expose internal representation by returning StorageMetadataImpl.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 115 | Medium |
| new org.jclouds.blobstore.domain.internal.StorageMetadataImpl(StorageType, String, String, Location, URI, String, Date, Map) may expose internal representation by storing an externally mutable object into StorageMetadataImpl.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.jclouds.http.HttpRequest to org.jclouds.rest.internal.GeneratedHttpRequest in org.jclouds.blobstore.functions.ParseSystemAndUserMetadataFromHeaders.setContext(HttpRequest) | STYLE | BC_UNCONFIRMED_CAST | 121 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.internal.BaseAsyncBlobStore.deleteAndEnsurePathGone(String) forgets to throw new IllegalStateException(String, Throwable) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 293 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.internal.BaseBlobStore.clearAndDeleteContainer(String) forgets to throw new IllegalStateException(String, Throwable) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 221 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.internal.BlobStoreContextImpl.equals(Object) checks for operand being a org.jclouds.rest.RestContext | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | 136 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.CreateContainerOptions.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 36 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.CreateContainerOptions$ImmutableCreateContainerOptions.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.GetOptions.getIfModifiedSince() may expose internal representation by returning GetOptions.ifModifiedSince | MALICIOUS_CODE | EI_EXPOSE_REP | 96 | Medium |
| org.jclouds.blobstore.options.GetOptions.getIfUnmodifiedSince() may expose internal representation by returning GetOptions.ifUnmodifiedSince | MALICIOUS_CODE | EI_EXPOSE_REP | 120 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.ListContainerOptions.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 39 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.ListContainerOptions$ImmutableListContainerOptions.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 59 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.ListOptions$ImmutableListOptions.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.PutOptions.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 33 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.options.PutOptions$ImmutablePutOptions.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 46 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.jclouds.blobstore.reference.BlobStoreConstants.DIRECTORY_SUFFIXES is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 41 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.jclouds.blobstore.util.BlobStoreUtils.getContentAsStringOrNullAndClose(Blob), since all java.io.InputStream are instances of java.io.InputStream | STYLE | BC_VACUOUS_INSTANCEOF | 140 | Medium |
